From 9b301059963b1299b9d1bee557933e7b46bd7b7f Mon Sep 17 00:00:00 2001 From: James Babcock Date: Sat, 7 Nov 2026 14:01:19 -0800 Subject: [PATCH] Less redundant Testflight privacy policy messages in onboarding --- app/analytics/privacy-disclosure.ts | 14 +++----- app/apps/onboarding/ios-privacy-page.ts | 43 ------------------------- app/apps/onboarding/onboarding-app.ts | 5 +-- app/phone-ui/onboarding-view-model.ts | 4 +-- app/ui/dashboard/settings-menus.ts | 6 ---- 5 files changed, 7 insertions(+), 65 deletions(-) delete mode 100644 app/apps/onboarding/ios-privacy-page.ts diff --git a/app/analytics/privacy-disclosure.ts b/app/analytics/privacy-disclosure.ts index 9cc2ed43..ede51f26 100644 --- a/app/analytics/privacy-disclosure.ts +++ b/app/analytics/privacy-disclosure.ts @@ -1,10 +1,6 @@ -/** Conditional wording: also shown on self-built iOS apps, where TestFlight does not apply. */ -export const IOS_PRIVACY_NOTICE = [ - "If installed with TestFlight, Apple automatically collects crash logs, installs, sessions, and device/app details and shares them with Faceclaw's developers. This continues even when Faceclaw statistics are None; the app cannot turn it off.", - "Joining only through a public link hides your name and email from us, not from Apple. Email invitations can identify you. Optional feedback can disclose your email, comments, screenshots and diagnostics. Review what you send.", - "iPhone Settings > Privacy & Security > Analytics & Improvements controls ordinary iOS analytics. It does not stop TestFlight crash reports. Faceclaw cannot change Apple's analytics settings.", - "To leave the beta, open Faceclaw in TestFlight and choose Stop Testing, then stop using and uninstall the beta. This does not erase earlier reports. Details: Settings > Privacy > Privacy policy.", -].join("\n\n"); - +/** + * One-line pointer for iOS. The full TestFlight disclosure lives only in the + * PRIVACY file (shown in-app as Settings > Privacy > Privacy policy). + */ export const IOS_PRIVACY_SUMMARY = - "With TestFlight, crash/usage reports continue even with None. Open iOS / TestFlight privacy for details."; + "With TestFlight, crash/usage reports continue even with None. See Privacy policy for details."; diff --git a/app/apps/onboarding/ios-privacy-page.ts b/app/apps/onboarding/ios-privacy-page.ts deleted file mode 100644 index dd3b94c6..00000000 --- a/app/apps/onboarding/ios-privacy-page.ts +++ /dev/null @@ -1,43 +0,0 @@ -import { IOS_PRIVACY_NOTICE } from "../../analytics/privacy-disclosure"; -import type { GrayImage } from "../../graphics/image"; -import { wrapText } from "../../graphics/textwrap"; -import type { InputEvent } from "../../ui/gestures"; -import { onboardingFont } from "./onboarding-fonts"; -import { drawPageHeading, PAGE_X, type OnboardingNav, type OnboardingPage } from "./onboarding-page"; - -/** Paginate the notice so no disclosure is silently clipped on a short glasses viewport. */ -export class IosPrivacyPage implements OnboardingPage { - readonly immersive = true; - private page = 0; - private pageCount = 1; - - enter(): void { this.page = 0; } - - paint(image: GrayImage): void { - const top = drawPageHeading(image, "iOS / TestFlight privacy", "") + 8; - const font = onboardingFont("detail"); - const lines = IOS_PRIVACY_NOTICE.split("\n\n").flatMap((paragraph, index) => [ - ...(index ? [""] : []), ...wrapText(font, paragraph, image.width - 2 * PAGE_X), - ]); - const perPage = Math.max(1, Math.floor((image.height - top - font.lineHeight - 20) / font.lineHeight)); - this.pageCount = Math.ceil(lines.length / perPage); - this.page = Math.min(this.page, this.pageCount - 1); - lines.slice(this.page * perPage, (this.page + 1) * perPage).forEach((line, index) => { - image.drawText(font, PAGE_X, top + index * font.lineHeight, line, 200); - }); - const action = this.page + 1 < this.pageCount ? "Tap for more" : "Tap to choose statistics"; - image.drawText(font, PAGE_X, image.height - font.lineHeight - 8, - `${this.page + 1}/${this.pageCount} - ${action}`, 230); - } - - handleInput(event: InputEvent, nav: OnboardingNav): void { - if (event.type === "click") { - if (this.page + 1 < this.pageCount) this.page++; - else nav.next(); - } else if (event.type === "scroll-down" || event.type === "swipe-up") { - this.page = Math.min(this.page + 1, this.pageCount - 1); - } else if (event.type === "scroll-up" || event.type === "swipe-down") { - this.page = Math.max(0, this.page - 1); - } - } -} diff --git a/app/apps/onboarding/onboarding-app.ts b/app/apps/onboarding/onboarding-app.ts index 66a7000d..fb799dc8 100644 --- a/app/apps/onboarding/onboarding-app.ts +++ b/app/apps/onboarding/onboarding-app.ts @@ -7,7 +7,6 @@ import { findSoundEffect, playSoundEffect } from "../../ui/sound-effects"; import { DataCollectionPage } from "./data-collection-page"; import { DepthPage } from "./depth-page"; import { DisplayModePage } from "./display-mode-page"; -import { IosPrivacyPage } from "./ios-privacy-page"; import { LayoutPage } from "./layout-page"; import { markGlassesOnboardingFinished, ONBOARDING_APP_ID } from "./onboarding-progress"; import type { OnboardingPage } from "./onboarding-page"; @@ -26,9 +25,7 @@ export const ONBOARDING_SURFACE_ID = "window:onboarding"; */ export function createOnboardingAppWindow(options: InProcessAppOptions): InProcessWindow { const pages: OnboardingPage[] = [ - new WelcomePage(), new TextSizePage(), - ...(global.isIOS ? [new IosPrivacyPage()] : []), - new DataCollectionPage(), new LayoutPage(), new DepthPage(), new DisplayModePage(), + new WelcomePage(), new TextSizePage(), new DataCollectionPage(), new LayoutPage(), new DepthPage(), new DisplayModePage(), ]; const app = createInProcessWindow({ appId: ONBOARDING_APP_ID, diff --git a/app/phone-ui/onboarding-view-model.ts b/app/phone-ui/onboarding-view-model.ts index e1c6ecf8..7309a08d 100644 --- a/app/phone-ui/onboarding-view-model.ts +++ b/app/phone-ui/onboarding-view-model.ts @@ -1,5 +1,4 @@ import { Frame, Observable, Screen } from "@nativescript/core"; -import { IOS_PRIVACY_NOTICE } from "../analytics/privacy-disclosure"; import { glassesTypeSetting, type GlassesType } from "../ui/dashboard-settings"; import { isPreviewOnlyMode } from "./onboarding-state"; @@ -61,8 +60,7 @@ function stepContent(step: OnboardingStep, glasses: GlassesType, previewOnly: bo return { headline: "Before You Continue", tagline: "", - body: `This software provides a custom user interface and functionality for the ${product} smart glasses. It is not created or supported by ${maker}. If this software somehow breaks your headset, this is not ${makerPossessive} fault and is not covered by the hardware's warranty. If this software doesn't break your headset, using this software may void the hardware's warranty anyways, at the sole discretion of ${maker}. This software is beta; don't rely on it for anything critically important.` + - (global.isIOS ? "\n\niOS / TestFlight privacy\n\n" + IOS_PRIVACY_NOTICE : ""), + body: `This software provides a custom user interface and functionality for the ${product} smart glasses. It is not created or supported by ${maker}. If this software somehow breaks your headset, this is not ${makerPossessive} fault and is not covered by the hardware's warranty. If this software doesn't break your headset, using this software may void the hardware's warranty anyways, at the sole discretion of ${maker}. This software is beta; don't rely on it for anything critically important.`, primaryLabel: "Agree", secondaryLabel: "Back", splash: false, diff --git a/app/ui/dashboard/settings-menus.ts b/app/ui/dashboard/settings-menus.ts index 0732d9bd..ec857aa6 100644 --- a/app/ui/dashboard/settings-menus.ts +++ b/app/ui/dashboard/settings-menus.ts @@ -23,7 +23,6 @@ import { type AsrModelId, } from "../../native/asr-model"; import { TextViewerLayer } from "../../apps/files/text-viewer"; -import { IOS_PRIVACY_NOTICE } from "../../analytics/privacy-disclosure"; import type { LayerContext } from "../layers"; import { drawRightValueMenuItem, openModalMenu, submenuItem, type MenuItem } from "../menu"; import { shell } from "../shell/shell"; @@ -245,11 +244,6 @@ function settingsSections(): SettingsSection[] { items: [ // First chosen in the on-glasses onboarding (app/apps/onboarding/). enumSettingMenuItem(dataCollectionSetting), - ...(global.isIOS ? [{ - label: "iOS / TestFlight privacy", - description: "Apple's beta reports are separate from Faceclaw statistics. Tap to read.", - onSelect: (ctx: LayerContext) => ctx.stack.push(new TextViewerLayer(IOS_PRIVACY_NOTICE, "iOS / TestFlight privacy")), - }] : []), bundledDocMenuItem("PRIVACY", "Privacy policy"), ], },